Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse data access module #124

Draft
wants to merge 23 commits into
base: dev
Choose a base branch
from
Draft

Dataverse data access module #124

wants to merge 23 commits into from

Conversation

abearab
Copy link

@abearab abearab commented Apr 14, 2024

Aim

Including a draft dataverse data collector as part of gget tool boxes.

e.g.

gget dataverse -j dataverse.json -o path-to-dir

Tasks

  • make a python module and CLI for data collection from dataverse
  • collect data for a list of datasets defined as a JSON
  • build a JSON file for a list of datasets deposited in a given dataverse DOI at certain version
  • collect data by providing a dataverse DOI and version

History

As part of GilbertLabUCSF/CanDI#34, related to #121, I draft a module to collect data from dataverse. Then I thought data collection from dataverse can be a more general functionality here as part of gget.

I mostly borrowed codes from gears/utils.py or TDC/load.py. However, there are other efforts such as pyDataverse and easyDataverse.

References

@abearab
Copy link
Author

abearab commented Apr 14, 2024

cc @amva13

@abearab abearab marked this pull request as ready for review April 14, 2024 08:59
@lauraluebbert
Copy link
Member

Hi Abe, this is great work, thank you! I'm pretty busy right now but I'll try to start merging asap.

I just have two thoughts at the moment:

  1. We'll need to add unittests for this module. Do you have any ideas on how they should look like?
  2. Having a json file as input is a relatively complex input type. Is there perhaps a way around this to simplify the input to the module?

@abearab abearab marked this pull request as draft April 14, 2024 22:09
@abearab
Copy link
Author

abearab commented Apr 14, 2024

Hi Laura,

  1. We'll need to add unittests for this module. Do you have any ideas on how they should look like?

I'll think about and add more commits asap.

  1. Having a json file as input is a relatively complex input type. Is there perhaps a way around this to simplify the input to the module?

That's true. I think this can work with dataverse DOI and/or just fileId. However, I personally think a json file can be a good option to list all files related to a single project or topic. I'll try to add more commits in this regard.

I made this a draft PR while I'm adding more commits.

@lauraluebbert lauraluebbert deleted the branch pachterlab:dev September 24, 2024 16:59
@lauraluebbert
Copy link
Member

Oops sorry didn't mean to close this

@abearab
Copy link
Author

abearab commented Sep 26, 2024

Oops sorry didn't mean to close this

Oh no worries, I also didn't get chance to finish what we discussed before. I have the changes in a fork so I'll open another PR in the future. Thanks :)

@lauraluebbert
Copy link
Member

No need, I'll reopen this one as soon as the unit tests are passing and I can make a new dev branch

@lauraluebbert lauraluebbert reopened this Sep 26, 2024
@lauraluebbert lauraluebbert deleted the branch pachterlab:dev September 26, 2024 00:17
@lauraluebbert
Copy link
Member

I did it again lol sorry

@lauraluebbert lauraluebbert reopened this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants