Skip to content

Commit

Permalink
Revert "Fix types"
Browse files Browse the repository at this point in the history
This reverts commit 09e27ea.
  • Loading branch information
taglioni-r committed Sep 25, 2024
1 parent 09e27ea commit 1bbe00c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions packages/client-assertion-validation/src/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ import {
ClientAssertion,
ClientAssertionValidationRequest,
ConsumerKey,
FailedValidation,
Key,
SuccessfulValidation,
ValidationResult,
} from "./types.js";
import {
Expand Down Expand Up @@ -115,20 +113,23 @@ type ValidationOutput = {

function isValidationSuccess(
validationResult: ValidationResult<unknown>
): validationResult is SuccessfulValidation<unknown> {
return "data" in validationResult && validationResult.data !== undefined;
): validationResult is Extract<typeof validationResult, { data: unknown }> {
return "data" in validationResult && Boolean(validationResult.data);
}

function isValidationError(
validationResult: ValidationResult<unknown>
): validationResult is FailedValidation {
): validationResult is Extract<typeof validationResult, { errors: unknown }> {
return "errors" in validationResult && Array.isArray(validationResult.errors);
}

function isAllValidationSuccess(
validationOutput: ValidationOutput
): validationOutput is {
[TKey in keyof ValidationOutput]: SuccessfulValidation<unknown>;
[TKey in keyof typeof validationOutput]: Extract<
(typeof validationOutput)[TKey],
{ data: unknown }
>;
} {
return Object.values(validationOutput).every(isValidationSuccess);
}
Expand Down Expand Up @@ -229,7 +230,6 @@ export const validateClientKindAndPlatformState = (
const validationResult = validatePlatformState(key as ConsumerKey);

if (isValidationSuccess(validationResult)) {
validationResult.data;
// ...
} else {
validationResult.errors;
Expand Down

0 comments on commit 1bbe00c

Please sign in to comment.