-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIN-5371 - delegation-readmodel-writer
#1065
base: feature/delegation-process
Are you sure you want to change the base?
PIN-5371 - delegation-readmodel-writer
#1065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, just some minor comments inline
}, | ||
{ | ||
$set: { | ||
data: delegation ? fromDelegationV2(delegation) : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which cases delegation
is undefined?
export const fromDelegationStampsV2 = ( | ||
input: DelegationStampsV2 | ||
): DelegationStamps => { | ||
if (!input.submission) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a possible case?
}; | ||
|
||
export const fromDelegationV2 = (input: DelegationV2): Delegation => { | ||
if (!input.stamps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still valid?
No description provided.