PIN-4810 clear tenant mail address #985
Conversation
rGregnanin
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Here I am removing strange characters or special symbols | ||
| const sanitizedMail = removeExtraSpace | ||
| .replace(/[^\w.@-_]/g, "") |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 5 hours ago
To fix the problem, we need to adjust the regular expression to avoid the overly permissive range. Specifically, we should remove the redundant underscore _ from the range and ensure that only the intended characters are included.
- General Fix: Replace the problematic character range with a more precise set of characters.
- Detailed Fix: Modify the regular expression on line 1758 to remove the redundant underscore and ensure that only the intended characters are included.
- Specific Changes: Update the regular expression in the
validateAddressfunction to use a more precise character set. - Requirements: No additional methods, imports, or definitions are needed to implement this change.
| @@ -1757,3 +1757,3 @@ | ||
| const sanitizedMail = removeExtraSpace | ||
| .replace(/[^\w.@-_]/g, "") | ||
| .replace(/[^\w.@-]/g, "") | ||
| .replace(/\^/g, ""); |
| @@ -1751,4 +1740,51 @@ async function revokeCertifiedAttribute( | |||
| } satisfies Tenant; | |||
| } | |||
|
|
|||
| function validateAddress(address: string): string { | |||
There was a problem hiding this comment.
IMHO there are too many steps in order to validate a mail, are these really necessary?
With the regex we don't need the extra steps of removing characters and spaces since it's already included.
I suggest to use this one: ^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}$ (taken from here)? Note: the regex must be case insensitive for it to work properly.
There's no perfect regex for validating a mail, but this one is simpler and covers most of the cases.
There was a problem hiding this comment.
I would prefer to leave emailPattern as it is so that it is aligned with the frontend as well, since it is the same pattern they use
No description provided.