IMN-792 Add events service v2 in agreement-platformstate-writer #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taglioni-r
changed the title
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
…IMN-792_agreement-platform-state-writer-v2
taglioni-r
commented
Oct 9, 2024
Comment on lines
+161
to
+164
| if (!catalogEntry) { | ||
| // TODO double-check | ||
| throw genericInternalError("Catalog entry not found"); | ||
| } |
There was a problem hiding this comment.
Double-check. Should this error be raised?
taglioni-r
commented
Oct 9, 2024
Comment on lines
+234
to
+237
| if (!secondRetrievalCatalogEntry) { | ||
| // TODO double-check | ||
| throw genericInternalError("Catalog entry not found"); | ||
| } |
There was a problem hiding this comment.
Double-check. Should this error be raised?
taglioni-r
requested review from
beetlecrunch,
galales,
AsterITA and
Carminepo2
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[To be merged after #967]
This pull request is for implementing the v2 consumer service in
agreement-platformstate-writer.