feat: [CHK-3298] add user stats api key in keyvault #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
pietro-tota
previously approved these changes
Oct 4, 2024
| @@ -486,6 +486,19 @@ resource "azurerm_key_vault_secret" "transactions_service_auth_update_api_key" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| resource "azurerm_key_vault_secret" "user_stats_api_key" { | |||
| name = "user-stats-api-key" | |||
There was a problem hiding this comment.
user-stats is an ecommerce microservice, who will invoke this api? I recommend adding a reference to the client in the name, the goal is to avoid using this api key unintentionally. If there are multiple clients internal or external to ecommerce, it is always better to differentiate the api keys
infantesimone
approved these changes
Oct 8, 2024
|
🎉 This PR is included in version 1.208.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add key-vault entry to store user-stats api key
List of changes
Motivation and context
Type of changes
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)