Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-822] feat: Add operator station review #396

Merged
merged 9 commits into from
May 28, 2024
Merged

[VAS-822] feat: Add operator station review #396

merged 9 commits into from
May 28, 2024

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • updated PUT /stations/wrapper/{station-code}/operator API to allow operator to add station review note
  • added email notification
  • updated unit tests
  • updated openapi

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added enhancement New feature or request minor labels May 22, 2024
@gioelemella gioelemella force-pushed the VAS-822-update-request-station-change-api branch from e98a9dc to 31947e5 Compare May 27, 2024 13:22
svariant
svariant approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@svariant svariant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 cool

@jacopocarlini jacopocarlini changed the base branch from main to next May 28, 2024 08:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gioelemella gioelemella added this pull request to the merge queue May 28, 2024
Merged via the queue into next with commit 7c8fd58 May 28, 2024
12 checks passed
@jacopocarlini jacopocarlini deleted the VAS-822-update-request-station-change-api branch May 29, 2024 13:28
jacopocarlini added a commit that referenced this pull request Jun 13, 2024
@gioelemella @jacopocarlini
[VAS-822] feat: Add operator station review (#396)
e61fa94 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
jacopocarlini added a commit that referenced this pull request Jun 19, 2024
@gioelemella @jacopocarlini
[VAS-822] feat: Add operator station review (#396)
cbb6881 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@gioelemella @jacopocarlini
[VAS-822] feat: Add operator station review (#396)
f2dd69e 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@gioelemella @jacopocarlini
[VAS-822] feat: Add operator station review (#396)
0d2cbd6 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svariant svariant svariant approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

Assignees

@gioelemella gioelemella

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gioelemella @svariant @jacopocarlini