Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-976] feat: add notice institutions api #401

Merged
merged 4 commits into from
May 29, 2024
Merged

[VAS-976] feat: add notice institutions api #401

merged 4 commits into from
May 29, 2024

Conversation

alessio-cialini
Copy link
Collaborator

List of Changes

  • Introducing API to update institutions for notices
  • Updated unit testing

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-cialini alessio-cialini added enhancement New feature or request minor labels May 28, 2024
@jacopocarlini jacopocarlini changed the base branch from main to next May 28, 2024 09:02
jacopocarlini
jacopocarlini approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 😄

@jacopocarlini
Copy link
Contributor

update_code

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@svariant svariant merged commit 39e0edf into next May 29, 2024
12 checks passed
jacopocarlini added a commit that referenced this pull request Jun 13, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
937f8b6 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 19, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
b6de229 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 19, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
747746c 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 19, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
b0851fc 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 19, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
1840694 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
ca1f569 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
330263c 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
339a5b0 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
8412720 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
c0b31d5 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
569e2ae 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
6fa82f3 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
4764a13 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
f014afe 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
c8625e9 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
0f93ff9 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
jacopocarlini added a commit that referenced this pull request Jun 24, 2024
@alessio-cialini @jacopocarlini @svariant
[VAS-976] feat: add notice institutions api (#401)
d9aa4b3 
Co-authored-by: Jacopo Carlini <jacopo.carlini@gmail.com>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@svariant svariant Awaiting requested review from svariant svariant is a code owner

@gioelemella gioelemella Awaiting requested review from gioelemella gioelemella is a code owner

Assignees

@alessio-cialini alessio-cialini

Labels
enhancement New feature or request minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-cialini @jacopocarlini @svariant