Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix flag async sync #405

Merged
merged 4 commits into from
May 29, 2024
Merged

Hotfix flag async sync #405

merged 4 commits into from
May 29, 2024

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • updated API to retrieve isConnectionSync flag from api-config response
  • updated openapi

Motivation and Context

VAS#1064

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added bug Something isn't working patch labels May 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jacopocarlini
jacopocarlini approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacopocarlini jacopocarlini added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@jacopocarlini jacopocarlini merged commit edca371 into main May 29, 2024
12 checks passed
@jacopocarlini jacopocarlini deleted the hotfix-flag-async-sync branch May 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

@svariant svariant Awaiting requested review from svariant svariant is a code owner

Assignees

@gioelemella gioelemella

Labels
bug Something isn't working patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @jacopocarlini