Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-962] feat: Implement authorizer when creating GPD key #450

Merged
merged 2 commits into from
Jul 5, 2024
Merged

[VAS-962] feat: Implement authorizer when creating GPD key #450

merged 2 commits into from
Jul 5, 2024

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Jul 2, 2024 •
edited
Loading

List of Changes

  • Implemented authorizer to verify user when creating a new api key for GPD service
  • Refactored and improved code

Motivation and Context

VAS-962

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the minor label Jul 2, 2024
@svariant svariant changed the base branch from main to next July 2, 2024 15:25
@svariant svariant changed the title [VAS-962] feat: Implement authorizator when creating GPD key [VAS-962] feat: Implement authorizer when creating GPD key Jul 2, 2024
jacopocarlini
jacopocarlini approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@gioelemella gioelemella merged commit f24f192 into next Jul 5, 2024
15 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacopocarlini jacopocarlini deleted the VAS-962-authorizer-gpd-api-key branch July 29, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

@gioelemella gioelemella Awaiting requested review from gioelemella gioelemella is a code owner

Assignees

@svariant svariant

Labels
minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svariant @jacopocarlini @gioelemella