Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-1168] feat: rework get institutions #458

Merged
merged 3 commits into from
Jul 18, 2024
Merged

[VAS-1168] feat: rework get institutions #458

merged 3 commits into from
Jul 18, 2024

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Jul 17, 2024 •
edited
Loading

List of Changes

  • Reworked api to retrieve institutions, defined using userInstitutions api and removing usage of deprecated api
  • Updated unit test
  • introduced cache for institutions retrieval api

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jacopocarlini jacopocarlini changed the title feat: rework get institutions [VAS-1168] feat: rework get institutions Jul 18, 2024
jacopocarlini
jacopocarlini reviewed Jul 18, 2024
View reviewed changes
CODEOWNERS Outdated Show resolved Hide resolved
@alessio-cialini alessio-cialini changed the base branch from main to next July 18, 2024 08:46
@alessio-cialini alessio-cialini requested a review from a team as a code owner July 18, 2024 08:46
@alessio-cialini alessio-cialini merged commit e02fdbe into next Jul 18, 2024
15 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacopocarlini jacopocarlini deleted the feat-rework-get-institutions branch July 29, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@svariant svariant Awaiting requested review from svariant svariant is a code owner

@gioelemella gioelemella Awaiting requested review from gioelemella gioelemella is a code owner

Assignees

@alessio-cialini alessio-cialini

Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-cialini @jacopocarlini