Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPANTT-153] fix: Improved error handling on authoizer config update #507

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[PPANTT-153] fix: Improved error handling on authoizer config update #507

merged 2 commits into from
Oct 9, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Oct 9, 2024 •
edited by jira bot
Loading

List of Changes

  • avoid subkey and authorization configuration recreate in case of missing authorization configuration
  • invoked update authorization API instead of delete and create API
  • improved log
  • updated unit tests

Motivation and Context

PPANTT-153

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella
[PPANTT-153] improved error handling by creating only the missing aut…
f6eb13b 
…horization config. Used update authorization API instead of delete and create. Improved log and updated unit tests
@gioelemella gioelemella merged commit bbc4b17 into main Oct 9, 2024
14 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-cialini alessio-cialini alessio-cialini approved these changes

@svariant svariant svariant approved these changes

Assignees

@gioelemella gioelemella

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gioelemella @alessio-cialini @svariant