Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use BP_GO_WORK_USE #768

Conversation

mamachanko
Copy link
Contributor

@mamachanko mamachanko commented Feb 13, 2024

Summary

Companion docs PR for paketo-buildpacks/go-build#537

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mamachanko mamachanko force-pushed the topic/mamachanko/main/bp_go_work_use branch from 2feefeb to 5983d78 Compare February 13, 2024 15:52
@ForestEckhardt
Copy link
Contributor

ForestEckhardt commented Feb 13, 2024

The only other thing the spell checker is worked up about is the word "workspaces" (not sure why) this can be fixed by adding it here https://github.com/mamachanko/paketo-website/blob/topic/mamachanko/main/bp_go_work_use/scripts/.util/spellcheck-dictionary.txt. If you would be willing to do that I would appreciate that!

Signed-off-by: Max Brauer <mbrauer@vmware.com>
@mamachanko mamachanko force-pushed the topic/mamachanko/main/bp_go_work_use branch from 5983d78 to 432b4d5 Compare February 13, 2024 15:55
@mamachanko mamachanko requested a review from a team as a code owner February 13, 2024 15:55
@mamachanko
Copy link
Contributor Author

The only other thing the spell checker is worked up about is the word "workspaces" (not sure why) this can be fixed by adding it here https://github.com/mamachanko/paketo-website/blob/topic/mamachanko/main/bp_go_work_use/scripts/.util/spellcheck-dictionary.txt. If you would be willing to do that I would appreciate that!

It's done!

Copy link
Contributor

@ForestEckhardt ForestEckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic thank you!

@ForestEckhardt ForestEckhardt merged commit 7068db5 into paketo-buildpacks:main Feb 13, 2024
3 of 4 checks passed
@mamachanko mamachanko deleted the topic/mamachanko/main/bp_go_work_use branch February 19, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants