Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle single unlisted images in geom_phylopic #76

Merged
merged 6 commits into from
Aug 27, 2023
Merged

Conversation

willgearty
Copy link
Collaborator

This wraps the image in a list if the user doesn't do it beforehand.

Fixes #75.

@willgearty willgearty added the bug label Aug 22, 2023
@willgearty willgearty added this to the 1.2.0 milestone Aug 22, 2023
@willgearty willgearty self-assigned this Aug 22, 2023
Copy link
Collaborator

@LewisAJones LewisAJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @willgearty, looks good, just some minor comments!

R/geom_phylopic.R Outdated Show resolved Hide resolved
R/geom_phylopic.R Show resolved Hide resolved
Copy link
Collaborator

@LewisAJones LewisAJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @willgearty! Thanks for updating the vignette here too!

@willgearty willgearty merged commit 337f4e5 into main Aug 27, 2023
8 checks passed
@willgearty willgearty deleted the wrap-image branch August 27, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geom_phylopic requires image to be in a list
2 participants