use JsonAlias for kabab case support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
reviewed
Jul 24, 2018
| @@ -1,4 +1,4 @@ | |||
| com.fasterxml.jackson.*:jackson-* = 2.6.7 | |||
| com.fasterxml.jackson.*:jackson-* = 2.9.5 | |||
There was a problem hiding this comment.
Is it work upgrading this to the minimum that allows us to use @JsonAlias?
There was a problem hiding this comment.
The minimum version is 2.9.0 and there are many bug fixes since then , so I am not sure if it is worth picking the minimum version if it is only patch bump.
qinfchen
added a commit
that referenced
this pull request
Jul 24, 2018
* update bintray to 1.8.4 (#102) * use JsonAlias for kabab case support (#106) htp-remoting/spark are already on jackson 2.9.5. Fixes palantir/conjure-java-runtime#317 worth mentioning https://github.com/palantir/http-remoting/releases/tag/3.33.0 release notes * merge develop and update locks
iamdanfox
pushed a commit
that referenced
this pull request
Sep 3, 2018
htp-remoting/spark are already on jackson 2.9.5. Fixes palantir/conjure-java-runtime#317 worth mentioning https://github.com/palantir/http-remoting/releases/tag/3.33.0 release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htp-remoting/spark are already on jackson 2.9.5. Fixes palantir/conjure-java-runtime#317
worth mentioning https://github.com/palantir/http-remoting/releases/tag/3.33.0 release notes