Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add comment about db.init_app #761

Merged
merged 1 commit into from
Jul 10, 2019
Merged

add comment about db.init_app #761

merged 1 commit into from
Jul 10, 2019

Conversation

matanw
Copy link

@matanw matanw commented Jul 8, 2019

No description provided.

@matanw matanw mentioned this pull request Jul 8, 2019
Closed
jab
jab reviewed Jul 9, 2019
View reviewed changes
Copy link
Member

@jab jab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: LGTM, other than the max line length looking like it’s been exceeded.

@matanw
Copy link
Author

matanw commented Jul 9, 2019

I really don't understand what is going on. om my "temp2" commit, code exactly same to the master, why the checks are failed?

@ThiefMaster
Copy link
Contributor

not related to your change

@matanw
Copy link
Author

matanw commented Jul 10, 2019 •
edited
Loading

OK; my pull reqruest is ready. can anyone approve and merge it?

@jab jab merged commit 4c48fe4 into pallets-eco:master Jul 10, 2019
@jab
Copy link
Member

jab commented Jul 10, 2019

Thank you for the contribution!

@matanw matanw deleted the comment_init_app branch July 10, 2019 19:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jab jab jab left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matanw @ThiefMaster @jab