Improved termui.pause() Function and Simplified Imports

[rly0nheart]

This pull request includes two main changes:

1. Pause Function Update:

   • The termui.pause() function has been improved by adding the default message ("Press any key to continue...") directly in the info param. This change improves readability and eliminates unnecessary checks for the info param
   • Additionally, I removed the if info checks since info will now have a default string value.

2. Simplified Import Statements:

   • Multiple imports from the same module have been combined into single lines to reduce clutter and make the codebase more maintainable.
   • Specifically, imports from _compat, exceptions, types, and other modules have been simplified.

Quick Question:
I noticed these imports here:

from .core import Argument as Argument
from .core import Command as Command
from .core import CommandCollection as CommandCollection
from .core import Context as Context
from .core import Group as Group
from .core import Option as Option
from .core import Parameter as Parameter
from .decorators import argument as argument
from .decorators import command as command
from .decorators import confirmation_option as confirmation_option
from .decorators import group as group
from .decorators import help_option as help_option
from .decorators import make_pass_decorator as make_pass_decorator
from .decorators import option as option
from .decorators import pass_context as pass_context
from .decorators import pass_obj as pass_obj
from .decorators import password_option as password_option
from .decorators import version_option as version_option
from .exceptions import Abort as Abort
from .exceptions import BadArgumentUsage as BadArgumentUsage
from .exceptions import BadOptionUsage as BadOptionUsage
from .exceptions import BadParameter as BadParameter
from .exceptions import ClickException as ClickException
from .exceptions import FileError as FileError
from .exceptions import MissingParameter as MissingParameter
from .exceptions import NoSuchOption as NoSuchOption
from .exceptions import UsageError as UsageError
from .formatting import HelpFormatter as HelpFormatter
from .formatting import wrap_text as wrap_text
from .globals import get_current_context as get_current_context
from .termui import clear as clear
from .termui import confirm as confirm
from .termui import echo_via_pager as echo_via_pager
from .termui import edit as edit
from .termui import getchar as getchar
from .termui import launch as launch
from .termui import pause as pause
from .termui import progressbar as progressbar
from .termui import prompt as prompt
from .termui import secho as secho
from .termui import style as style
from .termui import unstyle as unstyle
from .types import BOOL as BOOL
from .types import Choice as Choice
from .types import DateTime as DateTime
from .types import File as File
from .types import FLOAT as FLOAT
from .types import FloatRange as FloatRange
from .types import INT as INT
from .types import IntRange as IntRange
from .types import ParamType as ParamType
from .types import Path as Path
from .types import STRING as STRING
from .types import Tuple as Tuple
from .types import UNPROCESSED as UNPROCESSED
from .types import UUID as UUID
from .utils import echo as echo
from .utils import format_filename as format_filename
from .utils import get_app_dir as get_app_dir
from .utils import get_binary_stream as get_binary_stream
from .utils import get_text_stream as get_text_stream
from .utils import open_file as open_file

Is there a reason for using as when the names are the same?

I’m curious if there’s a specific reason for doing it this way, or if it’s something that could be simplified like so:

from .core import (
    Argument,
    Command,
    CommandCollection,
    Context,
    Group,
    Option,
    Parameter,
)

from .decorators import (
    argument,
    command,
    confirmation_option,
    group,
    help_option,
    make_pass_decorator,
    option,
    pass_context,
    pass_obj,
    password_option,
    version_option,
)

from .exceptions import (
    Abort,
    BadArgumentUsage,
    BadOptionUsage,
    BadParameter,
    ClickException,
    FileError,
    MissingParameter,
    NoSuchOption,
    UsageError,
)

from .formatting import HelpFormatter, wrap_text
from .globals import get_current_context
from .termui import (
    clear,
    confirm,
    echo_via_pager,
    edit,
    getchar,
    launch,
    pause,
    progressbar,
    prompt,
    secho,
    style,
    unstyle,
)

from .types import (
    BOOL,
    Choice,
    DateTime,
    File,
    FLOAT,
    FloatRange,
    INT,
    IntRange,
    ParamType,
    Path,
    STRING,
    Tuple,
    UNPROCESSED,
    UUID,
)

from .utils import (
    echo,
    format_filename,
    get_app_dir,
    get_binary_stream,
    get_text_stream,
    open_file,
)

Just want to understand the thought process behind it!

[davidism]

This is here for translation, which must happen dynamically, not in the default.

[rly0nheart]

NOW IT MAKES SENSE!

This makes me feel terrible about it😅

[davidism]

This doesn't happen.

[rly0nheart]

Oh?, I added that because I was seeing a warning in Pycharm

[davidism]

Typo

[davidism]

This style is deliberate and enforced by our formatting configuration.

[rly0nheart]

Ah! Okay, thanks :)

[davidism]

Thanks for your interest. However, we generally don't accept general refactors or style changes from outside contributors.

Is there a reason for using as when the names are the same?

They indicate that the names are re-exported for type checkers and formatters. And the style used is deliberate, as enforced by our formatter.