Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2952: Pin itsdangerous to below v1 #2953

Closed

Conversation

benvand
Copy link

@benvand benvand commented Oct 19, 2018

itsdangerous v1 has a breaking change that changes the session hashing algorithm.

Users would be signed out when an build of flask that has depended on the new itsdangerous v1.0 is released.

#2952

itsdangerous v1 has a breaking change that changes the session hashing algorithm.

Users would be signed out when an build of flask that has depended on the new itsdangerous v1.0 is released.

pallets#2952
@benvand benvand changed the title Pin itsdangerous to below v1 Fix #2952 Pin itsdangerous to below v1 Oct 19, 2018
@benvand benvand changed the title Fix #2952 Pin itsdangerous to below v1 Fix #2952: Pin itsdangerous to below v1 Oct 19, 2018
@ThiefMaster
Copy link
Member

I'm not sure if "sessions are cleared once" is worth pinning to an older version, especially since it's useless without doing a new release.

@benvand
Copy link
Author

benvand commented Oct 19, 2018

@ThiefMaster If you're running multiple apps that share a session then the app sessions are incompatible between the apps. That's how we found out.

@ThiefMaster
Copy link
Member

Updating all apps to the latest itsdangerous should help.

Anyway, while I still don't think we need to do a new Flask release, I do think we should pin all our dependencies to the current major versions to require an explicit Flask update to get a major version change in a dependency.

@davidism
Copy link
Member

Closing, see linked issue for response.

@davidism davidism closed this Oct 19, 2018
@davidism
Copy link
Member

davidism commented Oct 19, 2018

@ThiefMaster we can discuss version pinning policies in a new issue on pallets/meta if you'd like.

@benvand
Copy link
Author

benvand commented Oct 19, 2018

@ThiefMaster Totally agree about pinning deps
We have a complex environment of multiple apps and allowing flasks dependencies to have breaking changes damages the interoperability of those apps.

@benvand
Copy link
Author

benvand commented Oct 19, 2018

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants