Skip to content

Commit

Permalink
Default the PathConverter (and descendants) to be non part isolating
Browse files Browse the repository at this point in the history
This is likely to be the expected for anything that is or extends the
PathConverter and by adding it explicitly I hope it will cause less
confusion, as seen in a recent issue 2783.

Note the PathConverter was already non part isolating due to the
BaseConverter check.
  • Loading branch information
pgjones committed Sep 30, 2023
1 parent 4820d8c commit 6427542
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Unreleased
- Add the ``"werkzeug.profiler"`` item to the WSGI ``environ`` dictionary
passed to `ProfilerMiddleware`'s `filename_format` function. It contains
the ``elapsed`` and ``time`` values for the profiled request. :issue:`2775`
- Explicitly marked the PathConverter as non path isolating. :pr:`2784`


Version 2.3.8
Expand Down
1 change: 1 addition & 0 deletions src/werkzeug/routing/converters.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ class PathConverter(BaseConverter):
:param map: the :class:`Map`.
"""

part_isolating = False
regex = "[^/].*?"
weight = 200

Expand Down

0 comments on commit 6427542

Please sign in to comment.