CLN: remove redundant return value #31065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
approved these changes
Jan 16, 2020
|
Thanks @jbrockmendel |
huddlej
added a commit
to nextstrain/augur
that referenced
this pull request
Aug 11, 2020
The API for `parse_time_string` changed recently to only return two values instead of three [1] and the function is no longer importable from the pandas core tools datetimes module as of version 1.1.0. Instead, we have to import the `parsing` module that exposes the `parse_time_string` function. This bug should affect anyone trying to run augur with pandas 1.1.0 but not users running earlier versions of pandas. [1] pandas-dev/pandas#31065
huddlej
added a commit
to nextstrain/augur
that referenced
this pull request
Aug 11, 2020
The API for `parse_time_string` changed recently to only return two values instead of three [1] and the function is no longer importable from the pandas core tools datetimes module as of version 1.1.0. Instead, we have to import the `parsing` module that exposes the `parse_time_string` function. This commit supports both the previous and new API's return values. This bug should affect anyone trying to run augur with pandas 1.1.0 but not users running earlier versions of pandas. [1] pandas-dev/pandas#31065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.