Retain original _FillValue in encoding #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #471 that adds
_FillValue
to the retained encoding options. Based on #471 (comment),_FillValue
was initially excluded because it causes the tests to fail when asserting that the expected and actual schemas are equal. That fails because it's common to specify_FillValue
asnp.nan
and nans do not equal each other. This PR adds a_assert_schema_equal
that will treat NaNs in the schema as equal, so that the original_FillValue
can be retained.This PR is a prerequisite to #669 because we need to make all encoding options stored in
.zmetadata
follow valid JSON.