Add a fully transducer version of the core namespace #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also skipped stuff that seems unnecessary
Now I need to see how it works in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently somewhat experimental, but for many cases it seems to work great. I have not yet compared performance between the transducer and non-transducer versions.
I have not found a way to make the functions that explicitly handle loops (
all,deepest,descending,descents, etc) work as transducers. I am not certain whether that is even possible given that transducers are eager and queries on circular graph paths may easily be infinite.However, I think it's likely worthwhile to have transducer variants of queries available very common use case of non-circular queries.