Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove superfluous slashes #185

Merged
merged 1 commit into from
Mar 15, 2015
Merged

remove superfluous slashes #185

merged 1 commit into from
Mar 15, 2015

Conversation

diggy
Copy link
Contributor

@diggy diggy commented Mar 15, 2015

No description provided.

@panique
Copy link
Owner

panique commented Mar 15, 2015

This looks like it breaks the application. Can others please test this too ?
Thanks for the commit !

@panique panique closed this Mar 15, 2015
@panique panique reopened this Mar 15, 2015
@diggy
Copy link
Contributor Author

diggy commented Mar 15, 2015

APP is defined with a trailing slash (DIRECTORY_SEPARATOR), so the PR shouldn't break things (I tested locally), compare usage elsewhere e.g. require APP . 'controller/home.php'; in the Application class constructor.

@d1maz
Copy link

d1maz commented Mar 15, 2015

Yeah diggy is right, just tested and it works.

@panique
Copy link
Owner

panique commented Mar 15, 2015

Supercool, gentlemen! Thanks! I'll release this to master in the next days.

panique added a commit that referenced this pull request Mar 15, 2015
@panique
Merge pull request #185 from diggy/patch-app-slash
5df8b21 
remove superfluous slashes
@panique panique merged commit 5df8b21 into panique:develop Mar 15, 2015
@diggy diggy deleted the patch-app-slash branch March 16, 2015 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diggy @panique @d1maz