Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

SELFS-1359: Rename Rubocop YAML #95

Merged
merged 6 commits into from
Nov 23, 2021
Merged

Conversation

PeteHanner
Copy link
Contributor

@PeteHanner PeteHanner commented Nov 22, 2021

If you have your code editor set to highlight Rubocop linting errors as you type, some rules aren't getting picked up correctly. Most notably, the block length setting in this repo is getting ignored, so pretty much all of our spec files are getting highlighted in their entirety. Not only is it annoying and distracting, but it also can cover up actual linter errors that should be getting corrected.

When I searched for a solution to this issue, I found this GitHub thread in the rubocop repo pointing to how naming a gem's rubocop config as just rubocop.yaml messes up the pathing for any project that uses that gem.

All repos using panolint should do the following:

Update .rubocop.yml to change this section...

inherit_gem:
  panolint: rubocop.yml

...to instead say:

inherit_gem:
  panolint: panolint-rubocop.yml

Then, run the following in console on the same PR making the above change: BUNDLE_GEMFILE=.overcommit/Gemfile bundle update panolint --conservative

Finally, discard any changes that aren’t to the Panolint version number or revision hash number.

PRs have been opened in all the relevant PRs have been opened and can be found here.

@PeteHanner
Copy link
Contributor Author

The tests will fail here because the YAML config file was renamed, but subsequent PRs should be fine after merge since .github/workflows/tests.yml has been updated to reflect the new filename.

PeteHanner added a commit to panorama-ed/memo_wise that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/buildkite-assets that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/nora that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/rails_external_fields that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/scan_left that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/attribute_helpers that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/attribute_helpers that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/order_as_specified that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner added a commit to panorama-ed/unique_attributes that referenced this pull request Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
@PeteHanner PeteHanner merged commit 5850a21 into main Nov 23, 2021
@PeteHanner PeteHanner deleted the SELFS-1359-rename-rubocop-yaml branch November 23, 2021 16:40
JacobEvelyn pushed a commit to panorama-ed/memo_wise that referenced this pull request Nov 29, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn pushed a commit to panorama-ed/memo_wise that referenced this pull request Nov 29, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn pushed a commit to panorama-ed/scan_left that referenced this pull request Sep 28, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn pushed a commit to panorama-ed/scan_left that referenced this pull request Oct 3, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn pushed a commit to panorama-ed/scan_left that referenced this pull request Oct 3, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn pushed a commit to panorama-ed/scan_left that referenced this pull request Oct 3, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants