This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests will fail here because the YAML config file was renamed, but subsequent PRs should be fine after merge since |
PeteHanner
added a commit
to panorama-ed/memo_wise
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
2 tasks
PeteHanner
added a commit
to panorama-ed/buildkite-assets
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/nora
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/rails_external_fields
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/scan_left
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/attribute_helpers
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/attribute_helpers
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/order_as_specified
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
PeteHanner
added a commit
to panorama-ed/unique_attributes
that referenced
this pull request
Nov 23, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
honigc
approved these changes
Nov 23, 2021
honigc
approved these changes
Nov 23, 2021
JacobEvelyn
pushed a commit
to panorama-ed/memo_wise
that referenced
this pull request
Nov 29, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn
pushed a commit
to panorama-ed/memo_wise
that referenced
this pull request
Nov 29, 2021
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn
pushed a commit
to panorama-ed/scan_left
that referenced
this pull request
Sep 28, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn
pushed a commit
to panorama-ed/scan_left
that referenced
this pull request
Oct 3, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn
pushed a commit
to panorama-ed/scan_left
that referenced
this pull request
Oct 3, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
JacobEvelyn
pushed a commit
to panorama-ed/scan_left
that referenced
this pull request
Oct 3, 2022
Wait to merge until panorama-ed/panolint#95 has been merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have your code editor set to highlight Rubocop linting errors as you type, some rules aren't getting picked up correctly. Most notably, the block length setting in this repo is getting ignored, so pretty much all of our spec files are getting highlighted in their entirety. Not only is it annoying and distracting, but it also can cover up actual linter errors that should be getting corrected.
When I searched for a solution to this issue, I found this GitHub thread in the rubocop repo pointing to how naming a gem's rubocop config as just
rubocop.yaml
messes up the pathing for any project that uses that gem.All repos using panolint should do the following:
Update
.rubocop.yml
to change this section......to instead say:
Then, run the following in console on the same PR making the above change:
BUNDLE_GEMFILE=.overcommit/Gemfile bundle update panolint --conservative
Finally, discard any changes that aren’t to the Panolint version number or revision hash number.
PRs have been opened in all the relevant PRs have been opened and can be found here.