Skip to content

Commit

Permalink
Remove planners.py, which is too reliant on ambiguous rules to contin…
Browse files Browse the repository at this point in the history
…ue to support.
  • Loading branch information
stuhood committed Jul 25, 2018
1 parent 988d3f6 commit 5378da5
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 1,081 deletions.
3 changes: 3 additions & 0 deletions src/python/pants/engine/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ def __init__(self, scheduler, session):
self._session = session
self._run_count = 0

def assert_ruleset_valid(self):
self._scheduler._assert_ruleset_valid()

def graph_len(self):
return self._scheduler.graph_len()

Expand Down
15 changes: 0 additions & 15 deletions tests/python/pants_test/engine/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,6 @@ python_tests(
]
)

python_tests(
name='graph',
sources=['test_graph.py'],
coverage=['pants.engine.graph'],
dependencies=[
'3rdparty/python:future',
'src/python/pants/build_graph',
'src/python/pants/engine:scheduler',
'tests/python/pants_test/engine/examples:planners',
]
)

python_tests(
name='isolated_process',
sources=['test_isolated_process.py'],
Expand Down Expand Up @@ -135,7 +123,6 @@ python_tests(
'src/python/pants/engine:nodes',
'src/python/pants/engine:scheduler',
'src/python/pants/util:contextutil',
'tests/python/pants_test/engine/examples:planners',
'tests/python/pants_test/engine/examples:scheduler_inputs',
'tests/python/pants_test/engine:util',
]
Expand Down Expand Up @@ -201,7 +188,6 @@ python_tests(
'src/python/pants/engine:selectors',
'src/python/pants/util:objects',
'tests/python/pants_test/engine/examples:parsers',
'tests/python/pants_test/engine/examples:planners',
'tests/python/pants_test/subsystem:subsystem_utils',
]
)
Expand All @@ -216,7 +202,6 @@ python_tests(
'src/python/pants/base:cmd_line_spec_parser',
'src/python/pants/build_graph',
'src/python/pants/engine:scheduler',
'tests/python/pants_test/engine/examples:planners',
'tests/python/pants_test/engine/examples:scheduler_inputs',
]
)
Expand Down
53 changes: 0 additions & 53 deletions tests/python/pants_test/engine/examples/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,6 @@ python_library(
]
)

python_library(
name='planners',
sources=['planners.py'],
dependencies=[
'3rdparty/python:future',
':parsers',
':sources',
'src/python/pants/base:exceptions',
'src/python/pants/base:project_tree',
'src/python/pants/build_graph',
'src/python/pants/engine:build_files',
'src/python/pants/engine:fs',
'src/python/pants/engine:mapper',
'src/python/pants/engine:nodes',
'src/python/pants/engine:parser',
'src/python/pants/engine:scheduler',
'src/python/pants/engine:selectors',
'src/python/pants/engine:struct',
]
)

python_library(
name='sources',
sources=['sources.py'],
Expand All @@ -52,38 +31,6 @@ python_library(
]
)

python_library(
name='visualizer',
sources=['visualizer.py'],
dependencies=[
':planners',
'src/python/pants/base:cmd_line_spec_parser',
'src/python/pants/binaries',
'src/python/pants/build_graph',
'src/python/pants/engine:scheduler',
'src/python/pants/util:contextutil',
'src/python/pants/util:desktop',
'src/python/pants/util:process_handler',
'tests/python/pants_test/engine:util',
]
)

python_binary(
name='viz',
entry_point='pants_test.engine.examples.visualizer:main_addresses',
dependencies=[
':visualizer'
]
)

python_binary(
name='viz-fs',
entry_point='pants_test.engine.examples.visualizer:main_filespecs',
dependencies=[
':visualizer'
]
)

resources(
name='fs_test',
# Note that this test data dir is bundled into a tarfile, to preserve symlink structure
Expand Down
Loading

0 comments on commit 5378da5

Please sign in to comment.