Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception sink test is flaky #12108

Closed
Eric-Arellano opened this issue May 21, 2021 · 3 comments · Fixed by #12109 or #13539
Closed

Exception sink test is flaky #12108

Eric-Arellano opened this issue May 21, 2021 · 3 comments · Fixed by #12109 or #13539
Assignees

Comments

@Eric-Arellano
Copy link
Contributor

test_fails_ctrl_c_on_import seems to fail ~50% of our CI runs with an error like this:

>       assert "" == read_file(pid_specific_log_file)
326
E       assert equals failed
327
E         ''                               'Fatal Python error: Aborted\n\ 
328
E                                          nCurrent thread 0x00007f853deac 
329
E                                          700 (most recent call first):\n 
330
E                                          \nThread 0x00007f8541d6e740 (mo 
331
E                                          st recent call first):\n  File  
332
E                                          "/opt/hostedtoolcache/Python/3. 
333
E                                          7.10/x64/lib/python3.7/logging/ 
334
E                                          __init__.py", line 766 in _remo 
335
E                                          veHandlerRef\n'
336

337
src/python/pants/base/exception_sink_integration_test.py:127: AssertionError
@Eric-Arellano
Copy link
Contributor Author

Oh!! I suspect this flake was introduced with #12085. I haven't verified that, but I noticed CI has only been unusually unstable the past ~2 days and this was merged 3 days ago.

@Eric-Arellano
Copy link
Contributor Author

This is still flaking. Going to skip the test for now. It only started flaking recently, so it should be bisectable at least.

@Eric-Arellano Eric-Arellano reopened this May 24, 2021
Eric-Arellano added a commit that referenced this issue May 24, 2021
Turns out, #12085 was indeed not the cause of the flakiness seen in #12108. For now, we skip the test to stop the bleeding (~50% of CI runs fail).

[ci skip-rust]
@Eric-Arellano Eric-Arellano self-assigned this May 28, 2021
@Eric-Arellano
Copy link
Contributor Author

Running ./pants test --force --output=all src/python/pants/base/exception_sink_integration_test.py -- -k test_fails_ctrl_c_on_import -vv doesn't fail for me on both macOS and Ubuntu. Ran 20 times each.

stuhood added a commit that referenced this issue Nov 9, 2021
Unfortunately, it looks like `--no-print-stacktrace` broke in a critical location a while back, resulting in unnecessary noise. See for example: #13491 (comment)

Fix, and add an integration test. Also fixes the location of the `exceptions.log`, and removes `ExceptionSink` `Ctrl+C` tests, since `Ctrl+C` is now directly handled by the engine (fixes #12108).

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Nov 9, 2021
Unfortunately, it looks like `--no-print-stacktrace` broke in a critical location a while back, resulting in unnecessary noise. See for example: pantsbuild#13491 (comment)

Fix, and add an integration test. Also fixes the location of the `exceptions.log`, and removes `ExceptionSink` `Ctrl+C` tests, since `Ctrl+C` is now directly handled by the engine (fixes pantsbuild#12108).

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Nov 9, 2021
Unfortunately, it looks like `--no-print-stacktrace` broke in a critical location a while back, resulting in unnecessary noise. See for example: pantsbuild#13491 (comment)

Fix, and add an integration test. Also fixes the location of the `exceptions.log`, and removes `ExceptionSink` `Ctrl+C` tests, since `Ctrl+C` is now directly handled by the engine (fixes pantsbuild#12108).

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this issue Nov 9, 2021
Unfortunately, it looks like `--no-print-stacktrace` broke in a critical location a while back, resulting in unnecessary noise. See for example: #13491 (comment)

Fix, and add an integration test. Also fixes the location of the `exceptions.log`, and removes `ExceptionSink` `Ctrl+C` tests, since `Ctrl+C` is now directly handled by the engine (fixes #12108).

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this issue Nov 9, 2021
Unfortunately, it looks like `--no-print-stacktrace` broke in a critical location a while back, resulting in unnecessary noise. See for example: #13491 (comment)

Fix, and add an integration test. Also fixes the location of the `exceptions.log`, and removes `ExceptionSink` `Ctrl+C` tests, since `Ctrl+C` is now directly handled by the engine (fixes #12108).

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant