Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for setup_py_commands field #12658

Open
Eric-Arellano opened this issue Aug 26, 2021 · 0 comments
Open

Add tests for setup_py_commands field #12658

Eric-Arellano opened this issue Aug 26, 2021 · 0 comments
Labels
backend: Python Python backend-related issues

Comments

@Eric-Arellano
Copy link
Contributor

It looks like we don't have any tests that this gets consumed properly.

When adding tests, be sure to add a test that the default lockfile for setuptools works for all claimed interpreter versions, per #12601 and its linked PRs.

Eric-Arellano added a commit that referenced this issue Aug 26, 2021
…versions (#12656)

First part of #12601: we need to test that the default lockfile works for all expected Python versions. It's important that we not only install the tool PEX, but also run it to make sure there are no missing runtime dependencies.

_These tests do not yet actually consume the lockfile_, but that will happen soon once we change the default to be `<default>`. This is prework.

These tests will fail if the expected Python interpreters are not available in the environment. We definitely want to error in CI in that case, so we can fix CI to have the relevant interpreters. But this does mean `./pants test ::` is less likely to work for desktop use.

This does not test iPython and Setuptools because they don't have tests set up already: #12658 and #12657.

[ci skip-rust]
[ci skip-build-wheels]
@benjyw benjyw removed the tech-debt label Sep 9, 2021
@cognifloyd cognifloyd added the backend: Python Python backend-related issues label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Python Python backend-related issues
Projects
None yet
Development

No branches or pull requests

3 participants