Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: document plan for third-party dependency management #13050

Closed
Eric-Arellano opened this issue Sep 30, 2021 · 2 comments
Closed

Go: document plan for third-party dependency management #13050

Eric-Arellano opened this issue Sep 30, 2021 · 2 comments
Labels
backend: Go Go backend-related issues

Comments

@Eric-Arellano
Copy link
Contributor

Right now, we have the custom go-resolve goal. Should that hook up to ./pants generate-lockfiles?
@Eric-Arellano Eric-Arellano added the backend: Go Go backend-related issues label Sep 30, 2021
@Eric-Arellano
Copy link
Contributor Author

For simplicity, the first version of Go will rely on users using Go tooling to make sure that go.mod and go.sum are up-to-date. We will remove the go-resolve goal and also not hook up to generate-lockfiles.

Users are expected to run go mod tidy to make sure that their go.mod and go.sum are good. That is, Pants knows how to read those files, but not yet write them. This is similar to Python pre-#12314.

This is somewhat more acceptable because, for now, you must have Go installed already on your system to use it with Pants.

We'll document this and try to make our error messages helpful.

This was referenced Oct 1, 2021
Closed
Closed
Merged
Eric-Arellano added a commit that referenced this issue Oct 8, 2021
@Eric-Arellano
[internal] Remove go/custom_goals.py (#13166)
79f71d5 
`go-build` will soon be replaced by a `check` implementation. 

`go-resolve` should not exist because we decided in #13050 that third-party dependency management should be done independently of Pants for the first version of Go support.

[ci skip-rust]
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano changed the title Go: design and implement third-party dependency management Go: document plan for third-party dependency management Oct 11, 2021
@Eric-Arellano
Copy link
Contributor Author

Closing as duplicate of #13136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: Go Go backend-related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eric-Arellano