Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom javac test #5020

Closed
stuhood opened this issue Oct 26, 2017 · 0 comments
Closed

Fix custom javac test #5020

stuhood opened this issue Oct 26, 2017 · 0 comments
Assignees
@stuhood
Labels
bug

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Oct 26, 2017

#5011 introduced a failing test in master, which was skipped in order to land #5016 and prevent further breakage:

pants/tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_integration.py

Line 202 in 39bbec6

@skip("TODO: Fix post #5016.")

I'll work to fix this this evening.
@stuhood stuhood added the bug label Oct 26, 2017
@stuhood stuhood self-assigned this Oct 26, 2017
@stuhood stuhood mentioned this issue Oct 26, 2017
Merged
stuhood pushed a commit that referenced this issue Oct 26, 2017
Fix support for custom javac definitions (#5024)
beaa805 
### Problem

#5011 introduced a failure in an integration test which was missed due to #5019.

### Solution

Fix the test by moving the decision between using custom Javac and using the `tools.jar` out of `JavacPlugin` and into the `ProvideToolsJar` task (which runs after `bootstrap-jvm-tools`).

### Result

Fixes #5020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuhood