TestPantsDaemonIntegration.test_pantsd_run is flaky
#7573
Labels
Comments
jsirois
added a commit
to jsirois/pants
that referenced
this issue
Apr 15, 2019
jsirois
added a commit
that referenced
this issue
Apr 16, 2019
jsirois
added a commit
to jsirois/pants
that referenced
this issue
Mar 25, 2020
This brings our skip count up from 7 python and 2 rust to 25 python and 4 rust, hopefully in the name of stability as outlined in pantsbuild#9386. Also updates the How to Contribute docs with a pointer to pantsbuild#9386 for the latest procedure. Includes flaky tests from: pantsbuild#9313 pantsbuild#9312 pantsbuild#8679 pantsbuild#8678 pantsbuild#8520 pantsbuild#8520 pantsbuild#8520 pantsbuild#8405 pantsbuild#8193 pantsbuild#8171 pantsbuild#7836 pantsbuild#7622 pantsbuild#7573 pantsbuild#7572 pantsbuild#7554 pantsbuild#7547 pantsbuild#7457 pantsbuild#7168 pantsbuild#7149 pantsbuild#6838 pantsbuild#6829 pantsbuild#6787 pantsbuild#6114 [ci skip-jvm-tests] # No JVM changes made.
jsirois
added a commit
that referenced
this issue
Mar 25, 2020
This brings our skip count up from 7 python and 2 rust to 25 python and 4 rust, hopefully in the name of stability as outlined in #9386. Also updates the How to Contribute docs with a pointer to #9386 for the latest procedure. Includes flaky tests from: #9313 #9312 #8679 #8678 #8520 #8520 #8520 #8405 #8193 #8171 #7836 #7622 #7573 #7572 #7554 #7547 #7457 #7168 #7149 #6838 #6829 #6787 #6114
stuhood
added a commit
that referenced
this issue
Jun 15, 2020
### Problem Currently we restart pantsd for most configuration changes, and exclude a small set of bootstrap options (by marking them `daemon=False`) that should not trigger a restart. But in most cases, restarting is heavy-handed. We'd like to be able to keep more and more of our state alive over time as we continue to remove global mutable state (in order to allow us to tackle #7654, among other things). Additionally, the pantsd client currently implements the fingerprinting that decides when the server should restart, which blocks moving the pantsd client to rust. We'd like the client to only need to interact with a small set of options to simplify its implementation. ### Solution Move the nailgun server out of the `PantsService` model and directly into the `PantsDaemon` class. Share a `PantsDaemonCore` between the daemon and `DaemonPantsRunner` that encapsulates the current `Scheduler` and all live services. Finally, have the `PantsDaemonCore` implement fingerprinting to decide when to reinitialize/recreate the `Scheduler` (without restarting) and trim down the options that trigger a restart (`daemon=True`) to only those that are used to start the daemon itself (rather than to create the `Scheduler`). ### Result `pantsd` will stay up through the vast majority of options changes (with the exception of a handful of "micro-bootstrap" options), and will instead reinitialize the `Scheduler` for bootstrap options changes with some useful output when it does so. Example: ``` $ ./pants help 23:26:22 [INFO] initializing pantsd... 23:26:24 [INFO] pantsd initialized. Pants 1.30.0.dev0 https://pypi.org/pypi/pantsbuild.pants/1.30.0.dev0 Usage: <snip> $ ./pants --no-v1 help 23:26:31 [INFO] initialization options changed: reinitializing pantsd... 23:26:32 [INFO] pantsd initialized. Pants 1.30.0.dev0 https://pypi.org/pypi/pantsbuild.pants/1.30.0.dev0 Usage: <snip> ``` This prepares to port the client to rust, and unblocks a fix for #8200, by having the `PantsDaemon` class tear down the nailgun server cleanly in the foreground if any services exit. Fixes #6114, fixes #7573, and fixes #10041.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seen in nightly cron Ci job on 'Integration tests - shard 19 (Py2.7 PEX)' shard:
TestPantsDaemonIntegration.test_pantsd_run.failure.txt
The text was updated successfully, but these errors were encountered: