update libz-sys version to fix macOS compile error

[tdyas]

[ci skip-build-wheels]

Problem

Compile error on macOS 10.15.6 with libz-sys crate after pulling to latest master commit with Rust 1.47.0 upgrade:

The following warnings were emitted during compilation:

warning: src/zlib/gzlib.c:214:15: error: implicitly declaring library function 'snprintf' with type 'int (char *, unsigned long, const char *, ...)' [-Werror,-Wimplicit-function-declaration]
warning:         (void)snprintf(state->path, len + 1, "%s", (const char *)path);
warning:               ^
warning: src/zlib/gzlib.c:214:15: note: include the header <stdio.h> or explicitly provide a declaration for 'snprintf'
warning: 1 error generated.

error: failed to run custom build command for `libz-sys v1.0.25`

Solution

Ran cargo update -p libz-sys to upgrade libz-sys crate from v1.0.25 to v1.1.2.

Most of the churn in the Cargo.lock is probably from a newer version of Cargo which now pins versions by using a checksum field in the stanza for each crate.

Result

Ran ./pants --version with the upgraded libz-sys and native engine rebuilt successfully.

[tdyas]

Full error log:

The following warnings were emitted during compilation:

warning: src/zlib/gzlib.c:214:15: error: implicitly declaring library function 'snprintf' with type 'int (char *, unsigned long, const char *, ...)' [-Werror,-Wimplicit-function-declaration]
warning:         (void)snprintf(state->path, len + 1, "%s", (const char *)path);
warning:               ^
warning: src/zlib/gzlib.c:214:15: note: include the header <stdio.h> or explicitly provide a declaration for 'snprintf'
warning: 1 error generated.

error: failed to run custom build command for `libz-sys v1.0.25`

Caused by:
  process didn't exit successfully: `/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-660c6406c657a956/build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-env-changed=LIBZ_SYS_STATIC
  cargo:rerun-if-changed=build.rs
  TARGET = Some("x86_64-apple-darwin")
  OPT_LEVEL = Some("3")
  HOST = Some("x86_64-apple-darwin")
  CC_x86_64-apple-darwin = None
  CC_x86_64_apple_darwin = None
  HOST_CC = None
  CC = None
  CFLAGS_x86_64-apple-darwin = None
  CFLAGS_x86_64_apple_darwin = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2,sse3,ssse3")
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/adler32.o" "-c" "src/zlib/adler32.c"
  exit code: 0
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/compress.o" "-c" "src/zlib/compress.c"
  exit code: 0
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/crc32.o" "-c" "src/zlib/crc32.c"
  exit code: 0
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/deflate.o" "-c" "src/zlib/deflate.c"
  exit code: 0
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/gzclose.o" "-c" "src/zlib/gzclose.c"
  exit code: 0
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/gzlib.o" "-c" "src/zlib/gzlib.c"
  cargo:warning=src/zlib/gzlib.c:214:15: error: implicitly declaring library function 'snprintf' with type 'int (char *, unsigned long, const char *, ...)' [-Werror,-Wimplicit-function-declaration]
  cargo:warning=        (void)snprintf(state->path, len + 1, "%s", (const char *)path);
  cargo:warning=              ^
  cargo:warning=src/zlib/gzlib.c:214:15: note: include the header <stdio.h> or explicitly provide a declaration for 'snprintf'
  cargo:warning=1 error generated.
  exit code: 1

  --- stderr


  error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "src/zlib" "-fvisibility=hidden" "-DSTDC" "-D_LARGEFILE64_SOURCE" "-D_POSIX_SOURCE" "-o" "/Users/tdyas/TC/pants/src/rust/engine/target/release/build/libz-sys-8727e44b316d3267/out/build/src/zlib/gzlib.o" "-c" "src/zlib/gzlib.c" with args "cc" did not execute successfully (status code exit code: 1).


warning: build failed, waiting for other jobs to finish...
error: build failed

Failed to build native engine.

[coveralls]

Coverage remained the same at 0.0% when pulling be129bd on tdyas:update_libz_sys_crate into 842b9e2 on pantsbuild:master.

[tdyas]

And it is failing on:

thread 'tests::invalidate_randomly' panicked at 'In 0 iterations, observed a maximum of 1 distinct context values.', graph/src/tests.rs:193:3

https://travis-ci.com/github/pantsbuild/pants/jobs/397852400#L765

But which passes locally:

running 16 tests
test tests::critical_path ... ok
test tests::create ... ok
test tests::uncacheable_deps_is_cleaned_for_the_session ... ok
test tests::cyclic_failure ... ok
test tests::invalidate_and_rerun ... ok
test tests::invalidate_with_changed_dependencies ... ok
test tests::uncacheable_dependents_of_uncacheable_node ... ok
test tests::invalidate_and_clean ... ok
test tests::cyclic_dirtying ... ok
test tests::dirtied_uncacheable_deps_node_re_runs ... ok
test tests::poll_uncacheable ... ok
test tests::poll_cacheable ... ok
test tests::invalidate_randomly ... ok
test tests::retries ... ok
test tests::uncacheable_node_only_runs_once ... ok
test tests::canceled_immediately ... ok

test result: ok. 16 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests graph

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

[tdyas]

Now it passes after restarting the shard.