Remove experimental and unused [python-setup].requirement_constraints_target option and _python_constraints target
#11998
Conversation
…s_target` option and `_python_constraints` target # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
@benjyw I think this is the right decision to revert..I'm trying to recall our exact rationale for why we will not attempt parsing Iirc, in the future we may want to support Poetry first-class for lockfiles, but it would look more robust than this. I think @stuhood has been saying that the macro might not be the best approach, and I could envision even doing something like Pants running a Poetry subprocess to run FYI @wilsonliam, your thoughts welcome on this all :) -- Also this is a little bit of a gray area with the deprecation policy in removing an option w/o deprecation. My thinking is that the help message noted it was experimental and it required use of a private API |
|
Oh god I am not the right person to ask... I do not remember to this level of detail in this case. |
|
Maybe we should wait to land this until I've fully sketched out what multiple lockfiles will look like (building off of Stu's proposal). Otherwise I think there's going to be too much churn. |
|
While we're still finalizing some details from https://docs.google.com/document/d/1bCYb0UQZx9a-9tAagydCN_z3826QRvz_3aVnXKSNTJw/edit#, it's clear that this PR is regardless a good change to make. The proposal diverges a bit from what this PR reverts and keeping that code is noisy. |
This was added in #11724 to support a macro for Poetry for constraints files. But we recently decided that the macro will not support automatically reading
Poetry.lockbecause it is not very much to ask users to dopoetry --export. The macro will only operate onpyproject.toml. As suggested in https://docs.google.com/document/d/1bCYb0UQZx9a-9tAagydCN_z3826QRvz_3aVnXKSNTJw/edit#heading=h.11w5a92c1zo8, (for now) the lockfile format will look like requirements.txtThis PR's reverted code diverges from the tool lockfile proposal and it's getting in the way.
[ci skip-rust]
[ci skip-build-wheels]