[internal] Re-enable colors in CI #12141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
May 27, 2021
Merged
wisechengyi
added a commit
that referenced
this pull request
May 30, 2021
### Internal Changes * Prepare 2.5.1rc1 ([#12148](#12148)) * MultiGet accepts an arbitrary number of Gets. ([#12145](#12145)) * [internal] Re-enable colors in CI ([#12141](#12141)) * allow prepending args to the venv invocation ([#12137](#12137)) * Remove `dynamic_ui` and `colors` options from `pants.ci.toml` ([#12134](#12134)) * Prepare 2.5.1rc0 ([#12131](#12131)) * Prepare 2.4.2rc0 ([#12127](#12127)) * [internal] Turn on verbose logging in CI ([#12106](#12106)) * [internal] Restore #12085 and skip flaky test ([#12112](#12112)) * Revert "Use pytest tmp_path fixture (#12085)" to fix flaky test ([#12109](#12109)) * do not add a leading slash if REAPI instance name is empty ([#12103](#12103)) * Remove workaround for macOS failing to launch process with materialized argv0 ([#12095](#12095)) * Fix type hints for `UnionMembership.get()` ([#12092](#12092))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like our check
sys.stdout.isatty()results in disabling colors in CI, even though they are known to work with GitHub Actions and Travis.Fixing this robustly seems challenging, so instead (for now) we note this issue in our CI docs, given that this isn't a very problematic issue: https://www.pantsbuild.org/docs/using-pants-in-ci#configuring-pants-for-ci-pantscitoml-optional
[ci skip-rust]
[ci skip-build-wheels]