Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the arch in the venv directory path. #12192

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Jun 10, 2021

On M1 macs, it's common to need to reconfigure the architecture of your machine in various shells: we should invalidate the venv for this case.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood
Copy link
Sponsor Member Author

stuhood commented Jun 10, 2021

On my machine this is:

$ uname -mps
Darwin x86_64 i386

On an AWS Linux instance it is:

$ uname -mps
Linux x86_64 x86_64

Copy link
Contributor

@chrisjrn chrisjrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right

@stuhood stuhood merged commit 35c3a0f into pantsbuild:main Jun 10, 2021
@stuhood stuhood deleted the stuhood/arch-in-venv-dir branch June 10, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants