-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal] jvm/java: ensure JDK downloaded in one process #12972
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c3d7c34
add rule to ensure JDK is setup
6d97a77
port junit
10a7f2e
add util_rules to plugin registration
a3890b1
fix tests
11dd40b
remove unused JdkProcess type
294ef72
fmt
0300dab
fmt
e8db8ed
always invoke coursier for JAVA_HOME
2427ec0
remove debug stmt
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md). | ||
# Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
||
from __future__ import annotations | ||
|
||
from dataclasses import dataclass | ||
|
||
from pants.backend.java.compile.javac_subsystem import JavacSubsystem | ||
from pants.engine.fs import Digest | ||
from pants.engine.internals.selectors import Get | ||
from pants.engine.process import FallibleProcessResult, Process, ProcessResult | ||
from pants.engine.rules import collect_rules, rule | ||
from pants.jvm.resolve.coursier_setup import Coursier | ||
|
||
|
||
@dataclass(frozen=True) | ||
class JdkSetup: | ||
digest: Digest | ||
java_home_cmd: tuple[str, ...] | ||
fingerprint_comment: str | ||
|
||
|
||
@rule | ||
async def setup_jdk(coursier: Coursier, javac: JavacSubsystem) -> JdkSetup: | ||
if javac.options.jdk == "system": | ||
coursier_jdk_option = "--system-jvm" | ||
else: | ||
coursier_jdk_option = f"--jvm={javac.options.jdk}" | ||
|
||
java_home_result = await Get( | ||
FallibleProcessResult, | ||
Process( | ||
argv=( | ||
coursier.coursier.exe, | ||
"java-home", | ||
coursier_jdk_option, | ||
), | ||
input_digest=coursier.digest, | ||
description=f"Ensure download of JDK {coursier_jdk_option}.", | ||
), | ||
) | ||
|
||
if java_home_result.exit_code != 0: | ||
raise ValueError( | ||
f"Failed to determine JAVA_HOME for JDK {javac.options.jdk}: {java_home_result.stderr.decode('utf-8')}" | ||
) | ||
|
||
java_home = java_home_result.stdout.decode("utf-8").strip() | ||
|
||
version_result = await Get( | ||
ProcessResult, | ||
Process( | ||
argv=( | ||
f"{java_home}/bin/java", | ||
"-version", | ||
), | ||
description=f"Extract version from JDK {coursier_jdk_option}.", | ||
), | ||
) | ||
|
||
all_output = "\n".join( | ||
[ | ||
version_result.stderr.decode("utf-8"), | ||
version_result.stdout.decode("utf-8"), | ||
] | ||
) | ||
fingerprint_comment_lines = [ | ||
f"pants javac script using Coursier {coursier_jdk_option}. `java -version`:", | ||
*filter(None, all_output.splitlines()), | ||
] | ||
fingerprint_comment = "".join([f"# {line}\n" for line in fingerprint_comment_lines]) | ||
|
||
return JdkSetup( | ||
digest=coursier.digest, | ||
java_home_cmd=(coursier.coursier.exe, "java-home", coursier_jdk_option), | ||
fingerprint_comment=fingerprint_comment, | ||
) | ||
|
||
|
||
def rules(): | ||
return collect_rules() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed while rebasing #12982 that this line was lost: it's important when using the system JDK, because it isn't stable, and the fingerprint computation can't be cached. I doubt it's related to the current flakiness, but fyi.