[internal] Fix Go compilation of transitive dependencies #13083

Eric-Arellano · 2021-10-02T15:44:14Z

BuiltGoPackage was not properly preserving transitive dependencies, so at link time we would get errors like:

E           pants.engine.process.ProcessExecutionFailure: Process 'Link Go binary.' failed with exit code 1.
E           stdout:
E           cannot find package rsc.io/quote (using -importcfg)
E
E           stderr:
E           /opt/homebrew/Cellar/go/1.17/libexec/pkg/tool/darwin_arm64/link: cannot open file : open : no such file or directory

This fixes the issue and adds tests for import_analysis.py and build_go_pkg.py.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

tdyas

Thanks!

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Eric-Arellano · 2021-10-02T15:59:40Z

Woot, when combined with #13080, package_binary_integration_test.py now passes!

…pkg-transitive-deps [ci skip-rust] [ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

[internal] Fix Go compilation of transitive dependencies

9077da7

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Eric-Arellano requested a review from tdyas October 2, 2021 15:44

tdyas approved these changes Oct 2, 2021

View reviewed changes

Fix target expansion

fdc7846

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Eric-Arellano enabled auto-merge (squash) October 2, 2021 15:59

Eric-Arellano added 4 commits October 2, 2021 12:03

Merge branch 'main' of github.com:pantsbuild/pants into fix-build-go-…

8bf426d

…pkg-transitive-deps [ci skip-rust] [ci skip-build-wheels]

package_binary_integration_test.py passes now!

b837185

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Add missing __future__

0cfbbbd

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Fix test now that we don't depend on all external packages incorrectly

76c76f1

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Eric-Arellano merged commit 724615b into pantsbuild:main Oct 2, 2021

Eric-Arellano deleted the fix-build-go-pkg-transitive-deps branch October 2, 2021 18:48

stuhood mentioned this pull request Oct 11, 2021

Prepare 2.8.0.dev4. #13217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[internal] Fix Go compilation of transitive dependencies #13083

[internal] Fix Go compilation of transitive dependencies #13083

Eric-Arellano commented Oct 2, 2021

tdyas left a comment

Eric-Arellano commented Oct 2, 2021

[internal] Fix Go compilation of transitive dependencies #13083

[internal] Fix Go compilation of transitive dependencies #13083

Conversation

Eric-Arellano commented Oct 2, 2021

tdyas left a comment

Choose a reason for hiding this comment

Eric-Arellano commented Oct 2, 2021