Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Run pyupgrade src/python/pants/[util,options,testutil] #13107

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

asherf
Copy link
Member

@asherf asherf commented Oct 4, 2021

doing this in small batches to minimize interruption (i.e. other people need to rebase/deal with conflicts)

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

for typ in iter_types(item):
yield typ
yield from iter_types(item)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah! TIL. cc @stuhood @jsirois

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I stay away since I mostly need to keep 2.7 compatibility.

@Eric-Arellano Eric-Arellano merged commit 7329d6d into pantsbuild:main Oct 5, 2021
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Oct 5, 2021
…ntsbuild#13107)

doing this in small batches to minimize interruption (i.e. other people need to rebase/deal with conflicts)
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@asherf asherf deleted the newman branch October 5, 2021 11:00
@stuhood stuhood mentioned this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants