[internal] Use "file addresses" internally for some files and resources targets
#13188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urces` targets # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
benjyw
approved these changes
Oct 9, 2021
There was a problem hiding this comment.
This is in accord with the philosophy, but you can see how it sucks for the user: //BUILD_ROOT:files is more verbose than //:build_root, it includes two pieces of information instead of one, as previously, and the second piece of information is useless since it could in principle be determined unambiguously from just the first.
So really we should aim towards supporting just //BUILD_ROOT in the future :)
|
Agreed! I should have better clarified that my intention here is dogfooding, including highlighting the sh*it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insight from file targets and its target generator followup is that not all targets generated from the same generator necessarily need to act together as an atomic unit. You can bundle together things into a single target generator, and then callers depend on the more specific generated target to get what they need.
This applies that philosophy to two
files()andresources()target internal usages. No change in functionality, but tests out this mental model.[ci skip-rust]
[ci skip-build-wheels]