-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal] Use chevron instead of pystache to fix broken release process #13528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing that this was so easy to do. Thanks!!
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
changed the title
Switch to to use chevron instead of pystache to generate pants docs
[internal] Use chevron instead of pystache to generate pants docs
Nov 8, 2021
Eric-Arellano
changed the title
[internal] Use chevron instead of pystache to generate pants docs
[internal] Use chevron instead of pystache to fix broken release
Nov 8, 2021
Eric-Arellano
changed the title
[internal] Use chevron instead of pystache to fix broken release
[internal] Use chevron instead of pystache to fix broken release process
Nov 8, 2021
[ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Nov 8, 2021
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Nov 8, 2021
…ess (Cherry-pick of pantsbuild#13528) since pystache hasn't been updated since 2014. also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Nov 10, 2021
…ess (Cherry-pick of pantsbuild#13528) (pantsbuild#13535) since pystache hasn't been updated since 2014. also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since pystache hasn't been updated since 2014.
also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt