Fix published wheel RECORDs. #18219
Merged
Fix published wheel RECORDs. #18219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash format is fixed and a verification step added to prevent publishing invalid wheels going forward. Fixes pantsbuild#18111
|
I tested this out with a hacked up $ PY=python3.9 USE_PY39=true ./build-support/bin/release.sh publish
[=== 00:00 Releasing to PyPI and GitHub ===]
[=== 00:00 Fetching pre-built wheels for 2.16.0.dev6+git2983f166 ===]
Saving to /home/jsirois/dev/pantsbuild/jsirois-pants/dist/deploy.
Fetching https://binaries.pantsbuild.org/wheels%2Fpantsbuild.pants%2F2983f166e18b1c1a480b85bf722d16d514b41b17%2F2.16.0.dev6%2Bgit2983f166%2Findex.html
...
Fetching https://binaries.pantsbuild.org/wheels%2Fpantsbuild.pants%2F2983f166e18b1c1a480b85bf722d16d514b41b17%2F2.16.0.dev6%2Bgit2983f166%2Fpantsbuild.pants.testutil-2.16.0.dev6%2Bgit2983f166-py3-none-any.whl
Unpacking to: /tmp/tmp7ohr1anb/check-wheel/pantsbuild.pants-2.16.0.dev6...OK
Wrote whl with version 2.16.0.dev6 to /home/jsirois/dev/pantsbuild/jsirois-pants/dist/deploy/wheels/pantsbuild.pants/2983f166e18b1c1a480b85bf722d16d514b41b17/2.16.0.dev6/pantsbuild.pants-2.16.0.dev6-cp37-cp37m-macosx_10_15_x86_64.whl.
...
Unpacking to: /tmp/tmpxucwf4nn/check-wheel/pantsbuild.pants-2.16.0.dev6...OK
Wrote whl with version 2.16.0.dev6 to /home/jsirois/dev/pantsbuild/jsirois-pants/dist/deploy/wheels/pantsbuild.pants/2983f166e18b1c1a480b85bf722d16d514b41b17/2.16.0.dev6/pantsbuild.pants-2.16.0.dev6-cp38-cp38-manylinux2014_x86_64.whl.
Unpacking to: /tmp/tmpf63z1yx0/check-wheel/pantsbuild.pants-2.16.0.dev6...OK
Wrote whl with version 2.16.0.dev6 to /home/jsirois/dev/pantsbuild/jsirois-pants/dist/deploy/wheels/pantsbuild.pants/2983f166e18b1c1a480b85bf722d16d514b41b17/2.16.0.dev6/pantsbuild.pants-2.16.0.dev6-cp38-cp38-manylinux2014_aarch64.whl.
... |
benjyw
approved these changes
Feb 9, 2023
|
Should we cherry-pick to 2.15.x so the release wheels there can be valid? |
Yeah, I think that makes sense. Coming up. |
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Feb 9, 2023
The hash format is fixed and a verification step added to prevent publishing invalid wheels going forward. Fixes pantsbuild#18111 (cherry picked from commit 817db43)
jsirois
added a commit
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash format is fixed and a verification step added to prevent
publishing invalid wheels going forward.
Fixes #18111