Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten the deprecation for export without --resolve. #19000

Merged
merged 1 commit into from
May 15, 2023

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented May 12, 2023

The first release with this deprecation will be 2.16.x, so this isn't a user-facing change yet.

It doesn't seem necessary to drag out the deprecation until 2.23.x. Getting rid of this in 2.18.x,
at the same time as some tool lockfile deprecations expire, will allow us to delete a lot of complicated
code much sooner.

The first release with this deprecation will be 2.16.x,
and it really doesn't seem necessary to drag out the deprecation
until 2.23.x. Getting rid of this in 2.18.x, at the same time
as the tool lockfile changes, will allow us to more aggressively
delete a lot of complicated code.
@benjyw benjyw added this to the 2.16.x milestone May 12, 2023
@benjyw benjyw requested a review from stuhood May 12, 2023 23:47
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented May 12, 2023

I originally set this to 2.23.x but I'm not sure why. I think back then we had conversations about longer deprecation cycles, but this seems excessive even by those standards. And we have related deprecations targeting 2.18.x, so might as well get them all over with.

@benjyw benjyw merged commit cf82715 into pantsbuild:main May 15, 2023
@benjyw benjyw deleted the shorten_deprecation branch May 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants