Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CODEOWNERS #19024

Merged
merged 1 commit into from
May 18, 2023
Merged

Remove CODEOWNERS #19024

merged 1 commit into from
May 18, 2023

Conversation

thejcannon
Copy link
Member

As discussed in Slack, this isn't quite what we intended.

@thejcannon
Remove CODEOWNERS
26edc00 
As discussed in Slack, this isn't quite what we intended.
@thejcannon thejcannon added the category:internal CI, fixes for not-yet-released features, etc. label May 17, 2023
@thejcannon thejcannon requested a review from kaos May 17, 2023 16:23
@huonw
Copy link
Contributor

huonw commented May 17, 2023

For reference (in case someone is searching the repo to know why we don't use CODEOWNERS, in future): https://pantsbuild.slack.com/archives/C0D7TNJHL/p1684174959066479 / https://chat.pantsbuild.org/t/12011178/ok-one-thing-i-ve-noticed-about-codeowners-is-that-the-codeo#884f64a8-f210-4a91-9b7e-052c662aa7eb

OK, one thing I've noticed about CODEOWNERS is that the codeowner is still there even if reviewers are added. IMO I should've known that in hindsight.
So, I'm starting to be -1 on the change as that wasn't the intent.
Instead I might suggest we:

  • Migrate this to a GitHub Action -> "if there are no reviewers on a PR, add X, Y, or Z." Could still make it based on path.
  • Add a PR template which in a comment suggests to the PR author to leave it blank if they are unsure and someone will be added automatically

@thejcannon thejcannon merged commit d4b586b into main May 18, 2023
@stuhood stuhood mentioned this pull request May 18, 2023
Merged
@thejcannon thejcannon deleted the thejcannon-patch-2 branch May 19, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejcannon @huonw @kaos