Remove more 2.18.0.dev0 deprecations (follow up to #19073) #19077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
May 21, 2023
|
I'm not sure what's up with the CI failure that said to regenerate CI config. Why would this PR have anything to do with that? |
|
Strange. What do you get if you regen? |
|
I'm seeing the same thing in #19079 |
|
That was a bad merge on #18829, will fix |
|
Fix in #19080 |
The export_virtualenv_for_targets rule is unused as of pantsbuild#19073
cognifloyd
force-pushed
the
more-2.18-deprecations
branch
from
6289af5
to
f82f40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
export_virtualenv_for_targetsrule which is unused as of #19073 where we removed support for calling the export goal without--resolve.