Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pex_binary sandbox: Traversing dep graph, stopping after package targets #19155

Merged
merged 52 commits into from
Jul 15, 2023
Merged

pex_binary sandbox: Traversing dep graph, stopping after package targets #19155

merged 52 commits into from
Jul 15, 2023

Commits on Jun 1, 2023

  1. Stub possible transitive dependency filter predicate

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    9bd27d5 View commit details
    Browse the repository at this point in the history

  2. Move TransitiveTargetsRequest.predicate

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1b9c658 View commit details
    Browse the repository at this point in the history

  3. Add TransitiveTargetsWithoutTraversingPackagesRequest

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2609ec9 View commit details
    Browse the repository at this point in the history

  4. Add test_transitive_targets_with_do_traverse_deps_predicate

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    7dc7d3e View commit details
    Browse the repository at this point in the history

  5. Add test_transitive_targets_without_traversing_packages_request

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    b225969 View commit details
    Browse the repository at this point in the history

  6. Add test that fails without using TransitiveTargetsWithoutTraversingP… 

    …ackagesRequest

Next commit adds it to fix it.
    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    cf71d2f View commit details
    Browse the repository at this point in the history

  7. Make pex_from_targets test pass using TransitiveTargetsWithoutTravers… 

    …ingPackagesRequest
    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    b60bf88 View commit details
    Browse the repository at this point in the history

  8. fmt

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    8e0f126 View commit details
    Browse the repository at this point in the history

  9. Rename do_traverse..._predicate -> should_traverse..._predicate

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    be0d1e5 View commit details
    Browse the repository at this point in the history

  10. Add ShouldTraverseDepsPredicate type

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    852dc30 View commit details
    Browse the repository at this point in the history

  11. Make transitive_targets_without_traversing_packages_request a helper … 

    …instead of a rule
    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    96f90e4 View commit details
    Browse the repository at this point in the history

  12. Simplify applicable target partitioning 

    Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
    @cognifloyd @thejcannon
    cognifloyd and thejcannon committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f636fa5 View commit details
    Browse the repository at this point in the history

  13. Delegate roots include/exclude to should_traverse_deps_predicate

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    06de098 View commit details
    Browse the repository at this point in the history

  14. Fmt

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    e3aa9cc View commit details
    Browse the repository at this point in the history

  15. Fix test rule registration

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    7c0cd57 View commit details
    Browse the repository at this point in the history

  16. drop repeated test

    @cognifloyd
    cognifloyd committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    342ff01 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Add DependenciesRequest.should_resolve_deps_predicate

    @cognifloyd
    cognifloyd committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    ba77dcd View commit details
    Browse the repository at this point in the history

  2. Replace should_traverse_deps_predicate with should_resolve_deps_predi… 

    …cate
    @cognifloyd
    cognifloyd committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    28df365 View commit details
    Browse the repository at this point in the history

  3. fmt

    @cognifloyd
    cognifloyd committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    53883b2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    6b8f440 View commit details
    Browse the repository at this point in the history

  5. Add should_resolve_deps_predicate wherever include_special_cased_deps… 

    …=True
    @cognifloyd
    cognifloyd committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    45ff6ca View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Remove include_special_cased_deps flag

    @cognifloyd
    cognifloyd committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    b5f54a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Rename should_resolve_deps -> should_traverse_deps

    @cognifloyd
    cognifloyd committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    95ef2d8 View commit details
    Browse the repository at this point in the history

  2. Cleanup comments

    @cognifloyd
    cognifloyd committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c2528f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    41c58d9 View commit details
    Browse the repository at this point in the history

  2. Address review feedback (more descriptive names and comments) 

    Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
    @cognifloyd @thejcannon
    cognifloyd and thejcannon committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    c58ce11 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4bf61f3 View commit details
    Browse the repository at this point in the history

  2. Add ShouldTraverseDepsPredicate 

    This will replace the `include_special_cased_deps` flag
    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c95aa60 View commit details
    Browse the repository at this point in the history

  3. Handle SpecialCasedDependencies in ShouldTraverseDepsPredicate 

    This will replace the `include_special_cased_deps` flag
    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c2c6f26 View commit details
    Browse the repository at this point in the history

  4. Replace include_special_cased_deps=True flag with `should_traverse_… 

    …deps_predicate=always_traverse`
    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ef7a09f View commit details
    Browse the repository at this point in the history

  5. Drop include_special_cased_deps flag

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    e30672c View commit details
    Browse the repository at this point in the history

  6. fmt

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    941c3c2 View commit details
    Browse the repository at this point in the history

  7. Add ExplicitlyProvidedDependenciesRequest

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c1c9252 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'cognifloyd/deps-predicate' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    6edb7ad View commit details
    Browse the repository at this point in the history

  9. Add DepsTraversalPredicates class as a mini-namespace for predicates

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c1ed5a2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into cognifloyd/deps-predicate

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    39e5bde View commit details
    Browse the repository at this point in the history

  11. Correct type hints for DepsTraversalPredicates methods

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    434a8fb View commit details
    Browse the repository at this point in the history

  12. comment typo

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    945b50b View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into cognifloyd/deps-predicate

    @cognifloyd
    cognifloyd authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    869b91f View commit details
    Browse the repository at this point in the history

  14. Merge branch 'cognifloyd/deps-predicate' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2f62b6e View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    78e16a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add TraverseIfNotPackageTarget

    @cognifloyd
    cognifloyd committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0473c1e View commit details
    Browse the repository at this point in the history

  2. Add test for TraverseIfNotPackageTarget

    @cognifloyd
    cognifloyd committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2343cd3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cognifloyd/package-deps-traversal' into transitives-and… 

    …-packages
    @cognifloyd
    cognifloyd committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    65a7ab3 View commit details
    Browse the repository at this point in the history

  4. update to use TraverseIfNotPackagesTarget predicate

    @cognifloyd
    cognifloyd committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c9ec3eb View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    03d5e81 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    53bcbfd View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. fmt

    @cognifloyd
    cognifloyd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    15b58f2 View commit details
    Browse the repository at this point in the history

  2. Add TraverseDeps(Enum) and some documentation

    @cognifloyd
    cognifloyd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    30d5b58 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    064dd91 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'cognifloyd/package-deps-traversal' into transitives-and… 

    …-packages
    @cognifloyd
    cognifloyd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ff35750 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into transitives-and-packages

    @cognifloyd
    cognifloyd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    941a17f View commit details
    Browse the repository at this point in the history