-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace include_special_cased_deps
flag with should_traverse_deps_predicate
#19272
Commits on Jun 8, 2023
-
Add
ShouldTraverseDepsPredicate
This will replace the `include_special_cased_deps` flag
Configuration menu - View commit details
-
Copy full SHA for c95aa60 - Browse repository at this point
Copy the full SHA c95aa60View commit details -
Handle SpecialCasedDependencies in
ShouldTraverseDepsPredicate
This will replace the `include_special_cased_deps` flag
Configuration menu - View commit details
-
Copy full SHA for c2c6f26 - Browse repository at this point
Copy the full SHA c2c6f26View commit details -
Replace
include_special_cased_deps=True
flag with `should_traverse_……deps_predicate=always_traverse`
Configuration menu - View commit details
-
Copy full SHA for ef7a09f - Browse repository at this point
Copy the full SHA ef7a09fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e30672c - Browse repository at this point
Copy the full SHA e30672cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 941c3c2 - Browse repository at this point
Copy the full SHA 941c3c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1c9252 - Browse repository at this point
Copy the full SHA c1c9252View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ed5a2 - Browse repository at this point
Copy the full SHA c1ed5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39e5bde - Browse repository at this point
Copy the full SHA 39e5bdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 434a8fb - Browse repository at this point
Copy the full SHA 434a8fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 945b50b - Browse repository at this point
Copy the full SHA 945b50bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 869b91f - Browse repository at this point
Copy the full SHA 869b91fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0a808c - Browse repository at this point
Copy the full SHA f0a808cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a77b046 - Browse repository at this point
Copy the full SHA a77b046View commit details
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 412e994 - Browse repository at this point
Copy the full SHA 412e994View commit details
Commits on Jun 13, 2023
-
Turn ShouldTraverseDepsPredicate into a dataclass
closure functions have a useless hash. The hash of a function does not account for any closure vars, including unhashable mutable vars, so that hash is not reliable. Plus, every instance of a closure will have a different id, so there cannot be any reuse of anything cached based on the function's hash. Using a frozen dataclass bypasses these issues. We include the class's __call__ function as a field in the parent dataclass so that it is part of the __hash__ function generated by the @DataClass decorator. Using the class's __call__ is more stable than using an instance's function.
Configuration menu - View commit details
-
Copy full SHA for 0b91c76 - Browse repository at this point
Copy the full SHA 0b91c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57660a6 - Browse repository at this point
Copy the full SHA 57660a6View commit details -
Add test for frozen ShouldTraverseDepsPredicate subclasses
This tests 2 things: - that subclasses without an @DataClass decorator are still frozen - that mypy says the types of _callable and __call__ are compatible For the mypy issue, I tried using Self instead of Any, but Self resolved to ShouldTraverseDepsPredicate which did not match SkipDepsTagOrTraverse for some reason.
Configuration menu - View commit details
-
Copy full SHA for d0364f5 - Browse repository at this point
Copy the full SHA d0364f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b856127 - Browse repository at this point
Copy the full SHA b856127View commit details -
Co-authored-by: Joshua Cannon <joshdcannon@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ce2bce - Browse repository at this point
Copy the full SHA 7ce2bceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a28cd6 - Browse repository at this point
Copy the full SHA 6a28cd6View commit details