Bump minimum scie version to 0.10.0 (Cherry-pick of #19670) #19674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pantsbuild/scie-pants#250 for the required fix.
WorkerPants
added
the
category:internal
thejcannon
approved these changes
Aug 25, 2023
|
I'd suggest that this isn't strictly necessary for cherry picking, ie we don't need to get it in to 2.17.0. The scie-pants bug doesn't affect 2.17, and if someone gets the message about needing to upgrade they'll almost certainly upgrade to the latest 0.10 anyway. For people who've upgraded in the small window when 0.9 was the latest, they'll just get a prompt to upgrade to 0.10 when they start using Pants 2.18. What do you think about thus leaving this for 2.17.1 or just not cherry-picking at all to reduce risk for 2.17.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pantsbuild/scie-pants#250 for the required fix.