Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post suffixed-wheel release fixups #5152

Merged
merged 4 commits into from
Dec 2, 2017
Merged

Post suffixed-wheel release fixups #5152

merged 4 commits into from
Dec 2, 2017

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Dec 2, 2017

Problem

In order to complete the 1.4.0.dev22 release, a few additional edits to the release.sh script were necessary.

Solution

  1. Update find_pkg to locate wheels by version.
  2. Use a more portable implementation of case insensitive username matching.
  3. URL-escape S3 keys (since + has special meaning in URLs).
  4. Validate that if a whl is not cross-platform, we have it for exactly two platforms.

@stuhood stuhood mentioned this pull request Dec 2, 2017
Closed
kwlzn
kwlzn approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuhood stuhood merged commit 3740cc5 into pantsbuild:master Dec 2, 2017
@stuhood stuhood deleted the stuhood/post-suffixed-wheels-fixups branch December 2, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwlzn kwlzn kwlzn approved these changes

@jsirois jsirois Awaiting requested review from jsirois

@benjyw benjyw Awaiting requested review from benjyw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuhood @kwlzn