-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: JvmBinary has source/sources set by the engine, not ad-hoc #5858
WIP: JvmBinary has source/sources set by the engine, not ad-hoc #5858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel! Sorry for the hacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was good to read through this!
if source: | ||
if not isinstance(source, string_types): | ||
raise TargetDefinitionException(self, 'source must be a single relative file path') | ||
sources = [source] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there tests that cover these error cases?
sources = getattr(self, 'sources', None) | ||
source = getattr(self, 'source', None) | ||
|
||
if self.multiple_source_error_message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found multiple_source_error_message
here confusing. How about only_supports_source_kwarg_error_message
?
No description provided.