Update documentation to add more details about the resolution #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ity
reviewed
Jan 18, 2019
| dependencies that rely on platform-specific code. | ||
|
|
||
| Currently, Pants tries to resolve dependencies for every platform specified in the options | ||
| (either in the `[pyhton_setup]` field of a `pants.ini` file or via command line args such as |
| platforms=['current','linux-x86_64'] | ||
| ) | ||
|
|
||
| Will include wheels of every 3rdparty requirement for both 64-bit Intel Linux and whatever platform |
| (see [#7105](https://github.com/pantsbuild/pants/issues/7105)). | ||
| Therefore, in addition to specifying the platforms with which your binary is intended to be | ||
| compatible in the `platforms` field of your <a pantsref="bdict_python_binary">`python_binary`</a> | ||
| target, you will need to make files for each package and platform available at build time. |
There was a problem hiding this comment.
please add current behavior in terms of specifying how it works when platforms is added to the target itself and when thats updated in #7105, docs can be updated at the same time.
| `--python-setup-platforms='["linux-x86_64"]'`). These | ||
| <a href="https://pip.pypa.io/en/stable/reference/pip_wheel/">wheels</a> will be available to | ||
| <a pantsref="bdict_python_binary">`python_binary`</a> targets, which can include them with the | ||
| `platforms` field. For instance, the following target: |
There was a problem hiding this comment.
I found the subject here a little hard to follow. In particular, the sentence These wheels will be available to python_binary targets, which can include them with the platforms field. feels like it's saying the wheels can be included in the platforms field.
ity
approved these changes
Jan 22, 2019
|
|
||
| Tensorflow-gpu depends on some CUDA code, and therefore there _cannot_ be a wheel available for OSX. | ||
| In this case, pants will try to resolve `tensorflow-gpu` both for Linux and OSX, and will fail at resolve time, | ||
| even though the target only claims to support Linux. Discussion around this topic is being [#7105](https://github.com/pantsbuild/pants/issues/7105). |
|
Probably going to close this as #7105 changes the behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There has been some issues regarding platforms and how they resolve dependencies. #7087 #7105
Solution
I tried to expand a bit on the existing documentation to make it more clear that there is currently no way of resolving a binary for only a specific platform.
Result
Hopefully this should avoid other users being confused, and cases like #7087