Apply final set of Shellcheck fixes and turn on in CI #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are too difficult to get right. Better to just skip them.
Can't figure out how to fix.
Eric-Arellano
requested review from
stuhood,
illicitonion,
cosmicexplorer and
blorente
Eric-Arellano
commented
Jun 1, 2019
| @@ -6,4 +6,4 @@ | |||
| # Check for copies (-C) and moves (-M), so we don't get false positives when people do | |||
| # refactorings. -l50 bounds the time git takes to search for these non-additions. | |||
| # See git-diff(1) and https://stackoverflow.com/a/2299672/2518889 for discussion of these options. | |||
| exec git diff --cached --name-only --diff-filter=A -C -M -l50 | |||
| exec git --no-pager diff --cached --name-only --diff-filter=A -C -M -l50 | |||
There was a problem hiding this comment.
Depending on how the user has their git set up, this script would sometimes fail. For example, my git for some reason defaults to opening git diff through less.
Now, the script will work no matter what.
There was a problem hiding this comment.
I didn't know about this argument! Note that many programs (including git) will respect the PAGER env var, and I've usually done this by running the command with PAGER=cat -- but this is definitely better!
| @@ -6,4 +6,4 @@ | |||
| # Check for copies (-C) and moves (-M), so we don't get false positives when people do | |||
| # refactorings. -l50 bounds the time git takes to search for these non-additions. | |||
| # See git-diff(1) and https://stackoverflow.com/a/2299672/2518889 for discussion of these options. | |||
| exec git diff --cached --name-only --diff-filter=A -C -M -l50 | |||
| exec git --no-pager diff --cached --name-only --diff-filter=A -C -M -l50 | |||
There was a problem hiding this comment.
I didn't know about this argument! Note that many programs (including git) will respect the PAGER env var, and I've usually done this by running the command with PAGER=cat -- but this is definitely better!
illicitonion
approved these changes
Jun 3, 2019
cosmicexplorer
approved these changes
Jun 3, 2019
blorente
approved these changes
Jun 3, 2019
illicitonion
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of the work from #7698 and #7719.
Several of the problems are ignored because they are very difficult to correctly fix, and the behavior is not broken when ran locally and in CI so the cost of fixing is not deemed worth it.